Skip to content

Make daily bulk-claim faction defaults explicit - #338

Open
Guffawaffle wants to merge 1 commit into
STFC-Mod:devfrom
Guffawaffle:feature/daily-bulk-claim-explicit-default
Open

Guffawaffle wants to merge 1 commit into
STFC-Mod:devfrom
Guffawaffle:feature/daily-bulk-claim-explicit-default

Conversation

@Guffawaffle

Copy link
Copy Markdown
Contributor

Daily bulk-claim factions currently use an empty default to represent all three factions. This makes the default explicit (federation,klingon,romulan) and resolves missing, empty and whitespace-only values before populating the runtime faction list and generated configuration values. Existing blank configurations retain their behavior.

Adds none as an explicit opt-out from Federation, Klingon and Romulan dailies; other dailies remain eligible. Named subsets keep the existing comma-separated format. The English example and compatibility note document these values.

This is standalone against dev and does not depend on #333. Suggested merge order is this PR first, then reconciliation of #333's overlapping faction parser and example changes.

Validation:

  • Windows release build passed.
  • Local fixture compiled the actual loader/parser and string-helper functions; missing, blank, whitespace, subset, case/trim, and none cases passed, including runtime and generated-value assertions.
  • Three independent semantic reviews passed. Mac CI and gameplay smoke for this branch remain pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant