Repository navigation
Fixed static error: field projection Tree.top which does not exist - #18
Open
jurgenvinju wants to merge 1 commit into
Open
jurgenvinju wants to merge 1 commit into
jurgenvinju wants to merge 1 commit into
Conversation
This is a false negative by the current Rascal type-checker. The `.top` field only exists on implicitly generated start non-terminals like `start[Program]`. Refactored with semantic equivalence. But the rule for `start[Program]` is probably superfluous due to the recursive nature (automatic recursion) of `collect`. Doing this fix now because the PR ( usethesource/rascal#2551 ) that fixes many false positives and false negatives with respect to start symbols will trigger a true positive here soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a false negative by the current Rascal type-checker. The
.topfield only exists on implicitly generated start non-terminals likestart[Program].Refactored with semantic equivalence. But the rule for
start[Program]is probably superfluous due to the recursive nature (automatic recursion) ofcollect.Doing this fix now because the PR ( usethesource/rascal#2551 ) that fixes many false positives and false negatives with respect to start symbols will trigger a true positive here soon.