Repository navigation
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
dev 전체 테스트에서 실패하던 펀딩 테스트 5개(
AdminFundingApiIntegrationTest2,TumblbugFundingApiIntegrationTest3)를 정리합니다.커밋별로 다시 돌려 보니 #586(관리자 펀딩 주문·이용권 대시보드 API 확장, PR #596)부터 실패합니다. #584~#588 구간은 JwtFilter 401(#603)과 테스트 설정(#606) 때문에 전부 실패해서 가려져 있었습니다.
GET /api/v1/admin/funding/orders500 (테스트 2개)searchOrders쿼리에서 enum 파라미터를 상수와 비교(:deliveryStatus = DeliveryStatus.SUCCESS)해 Hibernate 가 타입을 정하지 못함. 필터 유무와 상관없이 항상 500deliveryStatus가 FAILED 를 내려주지 않음🐛 Fix
FundingOrderRepository.java,AdminFundingService.javaAdminFundingService.javaAdminFundingApiIntegrationTest.java,TumblbugFundingApiIntegrationTest.javaFUNDING_API.md📌 공유 사항
✅ 체크리스트
📸 스크린샷
💬 리뷰 요구사항