Repository navigation
Replace Windows Cargo check with Bazel CI - #4358
ScriptedAlchemy with Copilot wants to merge 13 commits into
Conversation
|
Co-authored-by: ScriptedAlchemy <[email protected]>
Co-authored-by: ScriptedAlchemy <[email protected]>
aa3d292 to
b2bb1a6
Compare
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed d74895d. Windows Bazel builds now honor the existing run-heavy scope gate, so draft PRs retain the lightweight path. Ready PRs and pushes compile the native Windows workspace; full Windows tests remain available through an explicit run_os dispatch. The workflow YAML parses, and diff/commitlint checks pass. Native Windows compilation remains assigned to CI.
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed ff2342a after the native CI failure reported four agent-hosts journeys timing out at their initial code-index generation.
The failing mount reaches a concrete pre-existing text-build admission defect: it added the watermark margin to the ledger reservation and then shrank it, so a build fitting the actual headroom could be refused by the larger temporary charge. This commit reuses the reviewed #4393 implementation that sizes and charges the build atomically under the canonical ledger, plus the cgroup-headroom regression already reviewed on #4379. It retains the existing ceiling, bounded reclamation, pressure/wakeup rules, and reservation owner.
The journey helper still uses its five-second deadline, 10 ms cadence, and original generation-ready condition. It now captures bounded park, worker, pressure, and ledger evidence inside that same deadline and signals the existing scheduler's cancellation on failure. Reporting after timeout performs no new readiness waits or diagnostic reads.
Validation: the transplanted production files match #4393 byte-for-byte; the added cgroup regression matches #4379. Independent source review, pinned rustfmt, diff checks, and commitlint pass. Native behavior remains for fresh CI. The old timeout log did not include enough admission state to prove this defect caused all four failures, so the diagnostic evidence remains necessary.
Summary
cfg(windows)code.workflow_dispatchwithrun_os=true.Motivation
The Linux Cargo check was the only automatic Windows compilation path, outside the workspace's Bazel build authority.
Changes
Test plan
bazel build //...passes when the change crosses package boundariesChecklist
CHANGELOG.mdupdated (under[Unreleased]if no version bump).envfiles included