Repository navigation
docs(release): remove unfinished Windows signing rollout - #4384
ScriptedAlchemy wants to merge 10 commits into
Conversation
|
4502bff to
f1be639
Compare
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed dcf78fedef54e08ce9dab33c499359b371bce11a for the inherited hook journey failure in CI run 39519779223. Both failed attempts were legitimately accepted for replay; the test assumed that its single retry would satisfy the unchanged 25 ms acknowledgement deadline.
The journey now retries the same immutable Stop event only after a completed accepted_for_replay, retryable: true receipt and typed replay Drained readiness. It uses one existing 180-second deadline across attempts. Exact guidance, single emission, duplicate suppression, and decision-engine assertions remain; production behavior and budgets are unchanged.
Pinned rustfmt, diff checks, and commitlint pass. Native execution is delegated to the new CI run.
This fixes the shared hook fixture. The separate fact_detail_keeps_a_superseded_fact_readable_by_id HTTP timeout in the previous run is not addressed by this change and remains for the new CI run to diagnose.
Choice and cause
Implements the removal option in #4341. No signing account, certificate, submission, download, or signature-verification stage is wired into either release channel or the shared package action. The checked-in SignPath portal XML and indefinite rollout wording implied that Windows executables would be signed even though published executables remain unsigned.
Changes
.signpath/artifact-configuration.xmlportal configuration.#79citation inSECURITY.mdwith the current unsigned state. This is a one-line edit because docs(security): clarify daemon authority and outbound operations #4348 also touches that file.Choosing signing instead would require provisioning a signing account and certificate, adding a required submission/download and publisher/chain verification step before both archive and MCPB packaging in stable and beta, failing publication on signing errors after a defined cutoff, and verifying the downloaded published artifacts on Windows. That wiring is outside this removal PR.
Verification
Before the change,
rg --hidden -n -i 'signpath|authenticode' .github .signpath scripts tests docs SECURITY.md README.mdfound the unused XML and SECURITY rollout claim; release workflows and shared package action had no signing stage. A red unit test is not applicable to this workflow/documentation cleanup.After the change,
rg --hidden -l -i 'signpath|authenticode'across the source tree returned no files; the only Windows signing statements now say the executables are unsigned.git diff --checkpassed. No workflow YAML changed, so actionlint is not applicable.bash tests/release_safety_test.sh, passed (exit 0)bash tests/release_drift_check_test.sh, passed (exit 0)bash tests/dashboard_bundle_check_test.sh, passed (exit 0)bash tests/release_pr_integrity_test.sh, passed (exit 0)scripts/check-release-drift.sh --release-version 1.0.0-beta.89printedrelease versions are aligned: 1.0.0-beta.89Bazel/clippy are not needed for a workflow and documentation cleanup with no code or workflow changes.
Fixes #4341