Repository navigation
目标对的指标还没读到数时写「还没读到数」,换指标时说清进度改从哪条算,reported 指标名去首尾空白 (#39) - #126
Merged
Merged
Conversation
…d 指标名去首尾空白、空名字回 400,验收 U9 按新规则讲 (#39) Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01XGuLYFbGRuBpdTFaXHrP9P
上一个提交把 TopicTask.metric、MetricReading.metric 改成判别联合,prompt 带的任务卡形状变了。 用升级前的 shared schema 去 parse 新版 prompt 会失败,旧代理过得了协议 4 的 hello 闸门, 之后却静默丢掉多 Bot 群的 prompt,run 一直挂着。照交付补强架构「改报文语义的单元,协议号和下限一起加一」, AGENT_PROTOCOL 和 MIN_AGENT_PROTOCOL 都改成 5,协议 4 的代理握手时直接用 4003 关,桌面端弹升级。 测试里的 hello 改报 5,低于下限的用例加上 4;控制面 README、开发文档、开发计划、部署文档里的数一起改。 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Be3SZps2JjqvyrJ1vbLmni
joesmart
force-pushed
the
joesmart/fix-goal-no-reading
branch
from
October 25, 2026 12:42
93dde02 to
fc1bbf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #39
改了什么
metric?.current ?? 0把「没有数」画成了0 / 5000。shared 里的TaskMetric改成判别联合{ kind: "unread" } | { kind: "read", current, weekDelta, sampledAt },TopicTask.metric、MetricReading.metric、TodayRunningItem.metric都用它;Web 的GoalProgress也分unread/read,unread的分支里拿不到current。读数器读失败但有旧值时,照 项目指标改成读数器注册表,一个项目挂多个指标,新增 X 粉丝数 (#39) #122 显示旧值和读到的时间,这部分没动。MetricSource的 reported label 改成z.string().trim().min(1).max(40),存的时候去掉首尾空白,全是空白在契约层回 400;landReported比较前两边都 trim,早先存下的带空格的名字照样对得上,不加迁移。合并时升协议号到 5。复核实测用旧版 shared 的 schema parse 新版 prompt 会失败,旧代理过得了协议 4 的 hello 闸门却静默丢掉多 Bot 群的 prompt,所以
AGENT_PROTOCOL和MIN_AGENT_PROTOCOL一起改成 5(单独一个提交),协议 4 的代理握手时直接拿到 4003 要升级。新用例,在 main 上都是红的
Bot 报的数名字带首尾空格照样对得上;挂指标时名字去掉首尾空格,空名字不收挂指标时名字去掉首尾空格,Bot 报「 粉丝 」落到「粉丝」;名字全是空格 400没有样本就是还没读到数,不拿 0 当当前值目标对的指标还没读到数:首页、项目页、群页任务卡都写「还没读到数」,不画 0 的进度条换「对哪个数」时表单下面说清进度改从哪条读数算,存好就不再提示怎么验证的
Web 整套跑时红了两条:
27-p2-team-web.spec.ts:699 名单补拉连着失败三趟就停…和28-p2-goal.spec.ts:363 复盘里一长串字不撑破成果栏…(Response has been disposed)。这两条没碰这次改的界面,各单跑 3 遍,6 次全过。28-p2-goal.spec.ts整个文件单跑也全绿。另外起了 mock,用 Playwright 在桌面和 390 宽各手点一遍:首页写「5000 粉丝 · 还没读到数」,项目页写「还没读到数 · 目标 5000 粉丝」,任务卡写「目标 5000 粉丝 · 还没读到数」,三处都没有 progress;提示文本正确,存好后消失;两种宽度下横向溢出都是 0px。截图不进仓库。
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGuLYFbGRuBpdTFaXHrP9P