fix: get_group_metadata called a non-existent endpoint (v0.1.2) - #12
Merged
Merged
Conversation
The API has no /facebook/groups/metadata route, so get_group_metadata() returned 404 on every call. It now calls /facebook/groups/details and returns the raw JSON, with a DeprecationWarning pointing to get_group_details(). Removal planned for 0.2.0. Bumps to 0.1.2 so PyPI also picks up the README fixes merged since 0.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
get_group_metadata()(sync and async) calledGET /facebook/groups/metadata. The API has no such route: the live API returns 404, andendpoints.jsonhas 50 routes, none of themgroups/metadata. Every call failed.Fix
/facebook/groups/detailsand return its raw JSON, so existing code keeps working instead of 404ing.DeprecationWarningpointing toget_group_details()(typedGroupInfo). Removal is planned for 0.2.0.Release
git tag v0.1.2 && git push --tagstriggersrelease.yml(Trusted Publishing).Tests
/groups/details, warns, and returns the data.ruff check,ruff format --check(ruff 0.16.10, same as CI),mypy socialapis testsandpytest(35 passed) all pass.