Repository navigation
add back in origin as an input option - #889
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new URL-helper imports are not exported by the pinned solid-logic package and will break the build.
2 open findings
What changed in this PR
Adds origin-based access grants to the access-control modal.
Changes:
- Recognizes, normalizes, displays, and saves origins.
- Includes origins in existing authorization editing.
- Adds origin styling and tests.
| File | Description |
|---|---|
AccessControlModal.ts |
Adds origin handling throughout the modal. |
AccessControlModal.styles.css |
Adds origin badge styling. |
types.ts |
Permits origin subjects. |
helpers.ts |
Removes the local HTTP URI helper. |
access-control-modal.test.ts |
Adds origin queuing coverage and updates fixtures. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
feat/add-origin
branch
from
October 11, 2026 07:50
90c90f0 to
2c4ed59
Compare
SharonStrats
enabled auto-merge
October 11, 2026 07:58
timea-solid
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Dokeili supports origin as we use it add it back in.