Repository navigation
Fix close - #891
Merged
Merged
Fix close#891
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The close behavior is correctly implemented and adequately tested.
0 open findings
What changed in this PR
Adds functional close handling to the error-state component while preserving an accessible button label.
Changes:
- Dispatches a bubbling, composed
closeevent when activated. - Adds screen-reader-only close text and event coverage.
| File | Description |
|---|---|
src/components/error-state/ErrorState.ts |
Implements accessible close-event handling. |
test/components/error-state.test.ts |
Verifies the label and dispatched event. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
timea-solid
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to handle the close, just added the button wasn't thinking 😅.