Skip to content

Revert "SCS-0128: Remove testcase that needs instance creation with admin password" - #1250

Merged
mbuechse merged 1 commit into
mainfrom
revert-1245-fzahn/scs-0128-drop-admin-pass-test
Oct 6, 2026
Merged

mbuechse merged 1 commit into
mainfrom
revert-1245-fzahn/scs-0128-drop-admin-pass-test

Conversation

@depressiveRobot

@depressiveRobot depressiveRobot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #1245

I mistakenly merged this too quickly. Most of the certified providers successfully run this check. This should first be discussed in the SIG Std/Cert.

@toothstone

Copy link
Copy Markdown
Contributor

Have you re-created my original PR somewhere? We need to track this somewhere.

@mbuechse

Copy link
Copy Markdown
Contributor

@toothstone What do you mean by 'recreated the PR'? It was never gone, and it's referenced in this PR's description.

@toothstone toothstone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to comply with you wish to discuss this in the SIG, I stand by my assessment that this test case should be dropped ;)

I've opened #1253 to re-apply my original PR in case this one here gets merged. In the future I would appreciate it if that wouldn't fall onto me.

@toothstone

Copy link
Copy Markdown
Contributor

Out of curiosity, why does this commit not need to be signed-off?

@toothstone

Copy link
Copy Markdown
Contributor

What does it mean for SCS-compatible IaaS v6 that this MR was not merged at the time of its stabilization? Is this feature part of it or not?

@mbuechse
mbuechse force-pushed the revert-1245-fzahn/scs-0128-drop-admin-pass-test branch from 0c8c8ce to 9876c09 Compare October 6, 2026 12:49
@mbuechse

mbuechse commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Wow. How was this not merged? It's pretty obvious from the SIG minutes that it was intended to be merged, and that the original PR had been merged by accident.

@mbuechse
mbuechse merged commit 1f68ca0 into main Oct 6, 2026
9 checks passed
@mbuechse
mbuechse deleted the revert-1245-fzahn/scs-0128-drop-admin-pass-test branch October 6, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants