Repository navigation
ci: run the Cypress plugins file on Cypress's bundled Node - #879
Merged
Merged
Conversation
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8cd2b4d. Configure here.
danielfsousa
marked this pull request as ready for review
October 21, 2026 02:50
rafaelmatsumotomb
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The Cypress Tests workflow fails on every pull request, and has since at least 2026-10-09. The first spec crashes in the plugins file with
Error: error:0308010C:digital envelope routines::unsupported, the next spec hangs, and the job is cancelled at its 30-minute timeout.Since Cypress 9, the plugins file runs on the Node that launched Cypress.
cypress-io/github-action@v6launches it from the runner's own Node 24, as the run header shows:Node Version: v24.19.0 (/home/runner/actions-runner/cached/2.337.0/externals/node24/bin/node), not the job's Node 16. Cypress 9's built-in webpack 4 hashes with MD4, which OpenSSL 3 in Node 17 and later rejects."nodeVersion": "bundled"incypress.jsonruns the plugins file on the Node that ships with Cypress 9 instead, whatever launched it. The option is deprecated and was removed in Cypress 13, so a Cypress upgrade removes this line too.Example of a failed run: https://github.com/SparkPost/support-docs/actions/runs/39530932672
Proof
Run on this PR on 2026-10-21, commit
8cd2b4df: https://github.com/SparkPost/support-docs/actions/runs/39534587871404.spec.tsindex.spec.tssubpage.spec.tsHow To Test or Verify
The Cypress Tests check on this PR runs all 3 specs (
404.spec.ts,index.spec.ts,subpage.spec.ts), and the run header shows the bundled Node rather thanexternals/node24.team - FENote
Low Risk
Single CI config flag in
cypress.json; no app or test logic changes, only how Cypress runs its plugins in GitHub Actions.Overview
Fixes failing Cypress CI by setting
"nodeVersion": "bundled"incypress.jsonso the plugins file runs on Cypress 9’s bundled Node instead of the runner’s Node 24.That avoids the
digital envelope routines::unsupportedcrash from webpack 4 / MD4 hashing under OpenSSL 3. The option is deprecated in Cypress 9 and removed in Cypress 13, so it should be dropped when Cypress is upgraded.Reviewed by Cursor Bugbot for commit 8cd2b4d. Bugbot is set up for automated code reviews on this repo. Configure here.