Repository navigation
Turn off optimize_palette in our colour selector - #288
Merged
alejoe91 merged 1 commit intoOct 15, 2026
Merged
Conversation
alejoe91
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I run the GUI, I get 4 divide by zero warnings for each color in our color palette. According to a friend, this is due to some weird BLAS bug which actually affects nothing.
But it turns out that the warning appears during optimization of the palette.
create_palettemakes an initial color palette guess, which is very good, than does a optimization by nudging each color a bit and seeing if this improves things. For our use case - finding ~20 colours that are as dissimilar as possible - the optimizations make no impact. So I propose turning it off rather than suppressing the warnings.