Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/spikeinterface/preprocessing/phase_shift.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ def __init__(self, recording, margin_ms=40.0, inter_sample_shift=None, dtype=Non
# for dumpability
if inter_sample_shift is not None:
inter_sample_shift = list(inter_sample_shift)
self._kwargs = dict(recording=recording, margin_ms=float(margin_ms), inter_sample_shift=inter_sample_shift)
self._kwargs = dict(
recording=recording,
margin_ms=float(margin_ms),
inter_sample_shift=inter_sample_shift,
dtype=np.dtype(dtype).str,
)


class PhaseShiftRecordingSegment(BasePreprocessorSegment):
Expand Down
14 changes: 13 additions & 1 deletion src/spikeinterface/preprocessing/tests/test_phase_shift.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import numpy as np
from spikeinterface import NumpyRecording
from spikeinterface import NumpyRecording, load
from spikeinterface.core.testing import check_recordings_equal

from spikeinterface.preprocessing import phase_shift

Expand Down Expand Up @@ -112,5 +113,16 @@ def signal(time):
np.testing.assert_allclose(shifted_traces[interior], expected[interior], atol=1e-3)


def test_phase_shift_dtype_survives_reload():
traces, sampling_frequency, inter_sample_shift = create_shifted_channel()
recording = NumpyRecording([traces.astype("int16")], sampling_frequency)
recording.set_property("inter_sample_shift", inter_sample_shift)

shifted = phase_shift(recording, dtype="float32")
reloaded = load(shifted.to_dict())

check_recordings_equal(shifted, reloaded, return_in_uV=False)


if __name__ == "__main__":
test_phase_shift()
Loading