Repository navigation
Add bison and flex to required packages - #41
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependencies use the existing installation flow, and no blocking issues were identified.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes missing build dependencies in the Nginx WAF installer.
Changes:
- Adds
bisonandflexfor building ModSecurity. - Bumps the script version to
v1.0.1and records the fix. - Adds TODO comments for update prompts and configuration preservation; behavior remains unchanged.
| File | Description |
|---|---|
hardening/Nginx WAF/nginx-waf.bash |
Adds dependencies, updates the version, and documents future improvements. |
hardening/Nginx WAF/CHANGELOG.md |
Records the dependency fix for v1.0.1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Nginx WAF installation script to fix a missing dependency issue and introduces several TODOs for future improvements. The main change ensures that all required packages are installed for building ModSecurity from source.
Dependency Fix:
bisonandflexto the list of required packages inC_REQUIRED_PKGSto resolve build issues with ModSecurity. [1] [2]Documentation Updates:
v1.0.1and updated the changelog to reflect the dependency fix. [1] [2]Future Improvements (TODOs):
modsecurity.confandcrs-setup.conffiles if they have been modified. [1] [2]