Skip to content

Add bison and flex to required packages - #41

Merged
StrangeRanger merged 4 commits into
mainfrom
dev
Oct 3, 2026
Merged

StrangeRanger merged 4 commits into
mainfrom
dev

Conversation

@StrangeRanger

Copy link
Copy Markdown
Owner

This pull request updates the Nginx WAF installation script to fix a missing dependency issue and introduces several TODOs for future improvements. The main change ensures that all required packages are installed for building ModSecurity from source.

Dependency Fix:

  • Added bison and flex to the list of required packages in C_REQUIRED_PKGS to resolve build issues with ModSecurity. [1] [2]

Documentation Updates:

  • Bumped the script version to v1.0.1 and updated the changelog to reflect the dependency fix. [1] [2]

Future Improvements (TODOs):

  • Added a TODO to check and offer to update ModSecurity instead of always fetching the latest version.
  • Added TODOs to prevent overwriting existing modsecurity.conf and crs-setup.conf files if they have been modified. [1] [2]

Copilot AI balanced review requested due to automatic review settings October 3, 2026 02:34
@StrangeRanger
StrangeRanger merged commit 395fb10 into main Oct 3, 2026
1 check was pending
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The dependencies use the existing installation flow, and no blocking issues were identified.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes missing build dependencies in the Nginx WAF installer.

Changes:

  • Adds bison and flex for building ModSecurity.
  • Bumps the script version to v1.0.1 and records the fix.
  • Adds TODO comments for update prompts and configuration preservation; behavior remains unchanged.
File Description
hardening/​Nginx WAF/​nginx-waf.bash Adds dependencies, updates the version, and documents future improvements.
hardening/​Nginx WAF/​CHANGELOG.md Records the dependency fix for v1.0.1.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants