Skip to content

feat(carousel): add swipeThreshold input and improve swipe navigation #187 - #733

Merged
intermetric merged 2 commits into
rcfrom
feat/187-carousel-sliding-threshold-improvement
Oct 23, 2026
Merged

intermetric merged 2 commits into
rcfrom
feat/187-carousel-sliding-threshold-improvement

Conversation

@intermetric

@intermetric intermetric commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Carousel swipes now settle more predictably, accounting for the release position, reachable stops, and quick flicks.
    • Added a configurable swipe threshold, defaulting to 0.3, to control how far users must drag to advance.
    • Canceled gestures return the carousel to its starting position; very short drags stay on the current stop.
  • Tests

    • Expanded coverage for swipe thresholds, flicks, cancellation, release movement, and fractional endpoints.

@intermetric
intermetric added this pull request to stack #734 September 25, 2026 12:56
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main changes: adding the swipeThreshold input and improving carousel swipe navigation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

♿ Accessibility — ✅ no blocking violations

No accessibility violations in the components changed by this PR.

🔕 Known issues — 20 stories marked todo (warn only)

Stories

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@intermetric intermetric linked an issue Sep 25, 2026 that may be closed by this pull request
@airikej

airikej commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

good change, maybe add swipeThreshold to reacts carousel too in the future?

@intermetric

Copy link
Copy Markdown
Contributor Author

@airikej

good change, maybe add swipeThreshold to reacts carousel too in the future?

Yup, makes sense. Created an issue: TEDI-Design-System/react#941.

@intermetric
intermetric force-pushed the feat/187-carousel-sliding-threshold-improvement branch from 942d905 to 0d82f29 Compare September 29, 2026 07:27
@intermetric
intermetric force-pushed the feat/187-carousel-sliding-threshold-improvement branch from 0d82f29 to ad1639a Compare September 29, 2026 07:33
Base automatically changed from feat/528-carousel-floating-buttons to rc September 29, 2026 07:38
@intermetric
intermetric force-pushed the feat/187-carousel-sliding-threshold-improvement branch from ad1639a to 10089bf Compare September 29, 2026 07:38
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

🎨 Chromatic

2 visual change(s) to review before merging.

Built from f602a70. Commits pushed after this are not covered; approve again to rebuild.

View the build

@intermetric
intermetric force-pushed the feat/187-carousel-sliding-threshold-improvement branch from f602a70 to 909dbb1 Compare October 22, 2026 13:39
@intermetric
intermetric force-pushed the feat/187-carousel-sliding-threshold-improvement branch from 909dbb1 to 69f0b01 Compare October 22, 2026 14:02
@intermetric
intermetric merged commit 834fa55 into rc Oct 23, 2026
37 of 38 checks passed
@intermetric
intermetric deleted the feat/187-carousel-sliding-threshold-improvement branch October 23, 2026 09:27
github-actions Bot pushed a commit that referenced this pull request Oct 23, 2026
# [9.0.0-rc.10](angular-9.0.0-rc.9...angular-9.0.0-rc.10) (2026-10-23)

### Features

* **carousel:** add swipeThreshold input and improve swipe navigation [#187](#187) ([#733](#733)) ([834fa55](834fa55))
@github-actions

Copy link
Copy Markdown

🎨 Chromatic

3 visual change(s) were detected on rc after this pull request merged.

Review and accept them

This branch was successfully deployed

1 active deployment
github-pages — 69f0b01c Deployed Oct 22, 2026 by intermetric via Deploy #1305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Carousel]: Sliding threshold

4 participants