Repository navigation
feat(client): make HTTP connect/read timeouts configurable - #73
Merged
Merged
Conversation
The KE client previously hardcoded a 5 s connect / 30 s read timeout (35 s for long-polling), which is too short for slower network environments. Add connect_timeout/read_timeout parameters to Client and KnowledgeBase, and corresponding fields on KnowledgeBaseSettings, so applications can raise these as needed. Defaults are unchanged. Fixes #71 Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #71.
The KE client hardcoded a 5 s connect / 30 s read timeout (35 s for the long-poll request), which can be too short for slower network environments (VPNs, congested networks, KE runtimes under heavy load).
Changes
Client.__init__now acceptsconnect_timeout(default5.0) andread_timeout(default30.0) parameters, used to build the underlyinghttpx.Timeout.read_timeout(read_timeout + 5.0margin) instead of being hardcoded to35.0.KnowledgeBase.__init__accepts and forwards the same two parameters toClient.KnowledgeBaseSettingsgainsconnect_timeout/read_timeoutfields (with defaults matching the previous hardcoded values), so config-driven KBs can set them via env vars / YAML / JSON.KnowledgeBaseBuilderforwards the settings values to the constructedKnowledgeBase.CONTEXT.mddocuments the new YAML settings fields.No behavioral change for existing users who don't set these — defaults are identical to the previous hardcoded values.