fix: NewsletterSignup crashes on undefined signupSources - #1303
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 341504a | Commit Preview URL Branch Preview URL |
Sep 28 2026, 11:08 PM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'includes')that occurred whenuser.signupSourceswasundefinedin theNewsletterSignupcomponent.The root cause was the line
user?.signupSources.includes('newsletter')which only guarded againstuserbeingundefined, but notuser.signupSources.Changes made:
src/components/NewsletterSignup.tsx, updated line 30 touser?.signupSources?.includes('newsletter') ?? falseto safely handle cases wheresignupSourcesmight beundefined.src/auth/auth.server.ts, updated themapDbUserToAuthUserfunction to ensuresignupSourcesdefaults to an empty array (user.signupSources ?? []) when constructing theAuthUserobject. This provides a server-side safeguard, though the client-side optional chaining is still necessary for robustness against stale client data or other edge cases.Fixes TANSTACK-COM-4W6
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.