You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
WebsosoTheme이 MaterialTheme 내부에서 텍스트 선택 색상을 제공합니다. 선택 핸들에는 Primary100을, 선택 배경에는 Primary50을 설정합니다.
Changes
테마 텍스트 선택 색상
Layer / File(s)
Summary
텍스트 선택 색상 제공 core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Theme.kt
Compose 텍스트 선택 API를 추가하고, CompositionLocalProvider에서 선택 핸들과 배경 색상을 각각 Primary100, Primary50으로 지정합니다. 콘텐츠는 색상 제공자 내부에서 렌더링됩니다.
The change is mergeable; only physical-device validation remains as normal follow-up.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
PR 제목은 텍스트 선택 핸들과 하이라이트 색상을 통일하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Description check
PR 설명은 이슈, 작업 내용, 원인, 변경 사항, 스크린샷, 리뷰어 안내를 포함합니다. 실기기 검증이 아직 완료되지 않았고 이슈 번호가 없지만, 핵심 변경 내용과 검증 상태는 충분히 설명되어 있습니다.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
브랜치명을 이슈 컨벤션(feat/981)으로 변경하면서 이 PR이 닫혀 #982 로 다시 올렸습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
컬렉션 작성 화면에서 텍스트를 선택할 때 나오는 핸들과 하이라이트 색을 피드 작성 화면과 같게 맞췄습니다.
원인
BasicTextField)은 커서 색만Primary100으로 지정하고, 핸들과 하이라이트는MaterialTheme기본값(colorScheme.primary기준)을 쓰고 있었습니다.WebsosoTheme은dynamicColor = true가 기본값이라, Android 12 이상에서는 핸들과 하이라이트가 배경화면 색을 따라갔습니다.Primary100에 알파 40%를 준 색이라, 피드의Primary50과 달랐습니다.변경
WebsosoTheme에서LocalTextSelectionColors를handleColor = Primary100,backgroundColor = Primary50으로 지정했습니다. 피드 작성 화면의colorControlActivated,textColorHighlight와 같은 색입니다.Primary100(보라)을 유지합니다.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
:core:designsystem,:feature:collection컴파일과ktlintCheck는 통과했고, 실기기 확인은 아직입니다.🤖 Generated with Claude Code
Summary by CodeRabbit