Skip to content

refactor(maths): clean up abs.py code style and remove print statement #15461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dyantqnili-png wants to merge 1 commit into from
Closed

refactor(maths): clean up abs.py code style and remove print statement #15461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions maths/abs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ def abs_val(num: float) -> float:

def abs_min(x: list[int]) -> int:
"""
>>> abs_min([0,5,1,11])
>>> abs_min([0, 5, 1, 11])
0
>>> abs_min([3,-10,-2])
>>> abs_min([3, -10, -2])
-2
>>> abs_min([])
Traceback (most recent call last):
Expand All @@ -30,16 +30,16 @@ def abs_min(x: list[int]) -> int:
raise ValueError("abs_min() arg is an empty sequence")
j = x[0]
for i in x:
if abs_val(i) < abs_val(j):
if abs(i) < abs(j):
j = i
return j


def abs_max(x: list[int]) -> int:
"""
>>> abs_max([0,5,1,11])
>>> abs_max([0, 5, 1, 11])
11
>>> abs_max([3,-10,-2])
>>> abs_max([3, -10, -2])
-10
>>> abs_max([])
Traceback (most recent call last):
Expand All @@ -57,9 +57,9 @@ def abs_max(x: list[int]) -> int:

def abs_max_sort(x: list[int]) -> int:
"""
>>> abs_max_sort([0,5,1,11])
>>> abs_max_sort([0, 5, 1, 11])
11
>>> abs_max_sort([3,-10,-2])
>>> abs_max_sort([3, -10, -2])
-10
>>> abs_max_sort([])
Traceback (most recent call last):
Expand Down Expand Up @@ -89,6 +89,3 @@ def test_abs_val() -> None:
import doctest

doctest.testmod()

test_abs_val()
print(abs_val(-34)) # --> 34
Loading