Repository navigation
DDIR: move the benchmarks to interactive/bench - #1012
Merged
frankmcsherry merged 2 commits intoOct 24, 2026
Merged
frankmcsherry merged 2 commits into
frankmcsherry merged 2 commits into
Conversation
server/bench/ held the LDBC and transaction benchmarks, which are clients of the server rather than part of it. They now sit at interactive/bench/, one directory each. This commit is the move alone; the next fixes the paths that name it. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o
- CI and every bench doc name interactive/bench/ for interactive/server/bench/. - run.py and suite.py find the repository root two levels up, not three, and bench_txn.py three, not four. - The two-session demo imports the LDBC client from ../../bench/ldbc. - The server README's links point to ../bench/. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o
frankmcsherry
changed the title
frankmcsherry
force-pushed
the
interactive-bench-move
branch
from
October 24, 2026 00:30
fb9eb15 to
4ae1cce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto master-next after #1011 merged; two commits, 9ddd582 and 4ae1cce.
Moves the benchmarks from
interactive/server/bench/tointeractive/bench/. They are clients of the server, not part of it.git mv interactive/server/bench interactive/bench, the move alone (188 files).interactive/bench/, along withcheck.py's docstring.run.pyandsuite.pyfind the repository root atparents[2], andbench_txn.pyatparents[3]. Both resolve to the git top level.../../bench/ldbc.../bench/.check.py's andreference.py's path inserts are relative to the LDBC directory, so they don't change.Checks:
cargo test -p interactive -p ddir-server: 199 passed.interactive/bench/ldbc.two_sessions.pypasses.bench_txn.pyrun completes from the new location.🤖 Generated with Claude Code
https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o