Repository navigation
DDIR server: split server.rs into one file per concern - #1014
Merged
frankmcsherry merged 1 commit intoOct 24, 2026
Merged
Conversation
`src/server.rs` (1,656 lines) is now `src/server/`, a pure move. `mod.rs` keeps
the registry: `Server` and what it holds per program, `Command`, `Published`,
and the lifecycle's ends, `tick` and `drop_program`. The rest is one file per
concern, each adding methods to `Server`:
- `time.rs`: `OuterTime`, `HostTime`, `host_time`, `host_dataflow`;
- `sources.rs`: positional inputs (`ServerInput`), the `random:`/`iota:`
recipes, the `clock`, and installing them;
- `install.rs`: `install` and its shape checks;
- `feed.rs`: `feed`, `feed_columns`, `load`, and their shared checks;
- `bind.rs`: `Binding`, `bind`, `unbind`, `binding_info`;
- `read.rs`: `snapshot_local`, `snapshot`, `peek`, `take_changes`;
- `diagnostics.rs`: the `diag.*` sources' wiring;
- `evaluate.rs`: `evaluate`, the test suites' entry point.
The public paths are unchanged: `interactive::server::{Server, evaluate,
host_dataflow, host_time, HostTime, OuterTime, ...}`. Items one file uses from
another are `pub(super)`; the rest stay private to their file.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o
frankmcsherry
force-pushed
the
ddir-server-split
branch
from
October 24, 2026 01:13
c46e37a to
4cb2154
Compare
frankmcsherry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto master-next after #1013 merged; one commit, 4cb2154.
Splits
src/server.rs(about 1.7k lines) intosrc/server/, one file per concern. It's a pure move; public paths don't change:interactive::server::{Server, evaluate, host_dataflow, host_time, HostTime, OuterTime, gen_field_seeded, …}. Items one file uses from another arepub(super), and everything else is private. 11 files, +1744/−1672.What escapes each file:
pub(super)items are visible only withinserver/.mod.rs:Serverregistry,tickand drop;evaluate,host_dataflow,host_time,HostTime,OuterTime,gen_field_seeded;pub:Published(withimport_containers),RowShape,HostContainer,Command,ProgramInfo, andServerwithnew,epoch,set_arranged_imports,set_export_taps,published,trace_shape,program_info,trace_info,drop_program,tick;Installed,Origin,Captured,fmt_shape.time.rs:OuterTime,HostTime,host_time,host_dataflow.sources.rs: inputs and generated sources.pub(super):InputContainer,COLUMN_BATCH,ServerInput,Recipe,clock_rows,generated_shape,canonical_source_name, and theServermethodsinstall_generated,install_clock,install_source.pub:gen_field_seeded, whichtests/explain.rsuses.hash_u64.install.rs:pub fn install; privatecheck_shapes.feed.rs:pub fn feed,feed_columns,load,loads_from_trace; privateload_trace,validate_feed.bind.rs:pub fn bind,unbind,binding_info;pub(super) Binding.read.rs:pub fn snapshot_local,snapshot,peek,take_changes.diagnostics.rs:pub fn set_diagnostics;pub(super)note_dataflow,process_diagnostics,feed_diagnostics,install_diagnostics.evaluate.rs:pub fn evaluate.hash_u64andgen_field_seeded, which #1011 moved intoserver.rs, now live insources.rsbesideRecipe. The README's host line namesserver/.Checks:
cargo test -p interactive -p ddir-server.interactive/bench/, includingauthored/check.py.server/*are exactly the onesserver.rshad, moved with their code. Nothing new.🤖 Generated with Claude Code
https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o