Skip to content

DDIR: rename the corgi module to runtime - #1015

Merged
frankmcsherry merged 1 commit into
TimelyDataflow:master-nextfrom
frankmcsherry:ddir-runtime-rename
Oct 24, 2026
Merged

frankmcsherry merged 1 commit into
TimelyDataflow:master-nextfrom
frankmcsherry:ddir-runtime-rename

Conversation

@frankmcsherry

Copy link
Copy Markdown
Member

Renames DDIR's columnar runtime module from src/corgi/ to src/runtime/. Today crate::corgi::… (DDIR's runtime) and corgi::… (the external crate) both appear throughout, and a reader can't tell which is meant. This is a pure rename, with no behaviour change. 33 files, +95/−95.

What changes

  • git mv interactive/src/corgi/** interactive/src/runtime/**: 14 files, so history follows.
  • 66 crate::corgi:: paths become crate::runtime::.
  • 27 interactive::corgi:: paths become interactive::runtime::, in the server crate, the tests, bench/ldbc/client.py and the server README.
  • pub mod corgi; becomes pub mod runtime; in lib.rs.
  • The README's Architecture section names runtime/.

Filtering the diff for lines that aren't one of these path rewrites leaves only the mod line and that README line.

Unchanged on purpose

  • Every reference to the external crate: corgi::Value, corgi::Shape, use corgi::…, corgi::bytes, and the Cargo dependency.
  • backend/corgi.rs, tests/corgi_backend.rs and tests/corgi_chunk_merge.rs. They name the corgi-backed implementation and what it's tested on.
  • Type names with the Corgi prefix. A follow-up could rename the ones that name a role rather than corgi-valued data:
    • data types, which keep the prefix: CorgiChunk, CorgiContainer, CorgiChunker, CorgiDistributor;
    • role types, which could be named for their role: CorgiBackend, CorgiImport, CorgiPact, CorgiHalfJoin, CorgiJoinBackend, CorgiReduceBackend.
  • runtime/mod.rs's header still reads "The corgi rendering substrate's internals". It describes the code, not the path.

Checks:

  • cargo test -p interactive -p ddir-server.
  • Clippy: 226 warnings on this branch and 226 on master-next, and the two lists are identical once src/runtime/ is mapped back to src/corgi/.
  • Every step of the release LDBC job, against a release server built from this branch, including authored/check.py --fixture --workers 4.
  • Release explain suite: 29/29.
  • Differential testing, seeds 20,261,023–20,266,022 with all nine oracles: 5,000 passed.
  • git grep "crate::corgi\|interactive::corgi\|src/corgi" returns nothing.

🤖 Generated with Claude Code

https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o

`interactive/src/corgi/` is DDIR's columnar runtime: containers, chunks,
join/reduce/half-join backends, exchange, time columns, and the feed and
frame formats. It was named after the external `corgi` crate whose values
it stores, so `crate::corgi::…` and `corgi::…` read alike. It is now
`crate::runtime`; references to the external crate are unchanged, as are
the `Corgi`-prefixed type names and `backend/corgi.rs`.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o
@frankmcsherry
frankmcsherry merged commit a4b0c05 into TimelyDataflow:master-next Oct 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant