Repository navigation
DDIR: rename the corgi module to runtime - #1015
Merged
frankmcsherry merged 1 commit intoOct 24, 2026
Merged
Conversation
`interactive/src/corgi/` is DDIR's columnar runtime: containers, chunks, join/reduce/half-join backends, exchange, time columns, and the feed and frame formats. It was named after the external `corgi` crate whose values it stores, so `crate::corgi::…` and `corgi::…` read alike. It is now `crate::runtime`; references to the external crate are unchanged, as are the `Corgi`-prefixed type names and `backend/corgi.rs`. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames DDIR's columnar runtime module from
src/corgi/tosrc/runtime/. Todaycrate::corgi::…(DDIR's runtime) andcorgi::…(the external crate) both appear throughout, and a reader can't tell which is meant. This is a pure rename, with no behaviour change. 33 files, +95/−95.What changes
git mv interactive/src/corgi/** interactive/src/runtime/**: 14 files, so history follows.crate::corgi::paths becomecrate::runtime::.interactive::corgi::paths becomeinteractive::runtime::, in the server crate, the tests,bench/ldbc/client.pyand the server README.pub mod corgi;becomespub mod runtime;inlib.rs.runtime/.Filtering the diff for lines that aren't one of these path rewrites leaves only the
modline and that README line.Unchanged on purpose
corgi::Value,corgi::Shape,use corgi::…,corgi::bytes, and the Cargo dependency.backend/corgi.rs,tests/corgi_backend.rsandtests/corgi_chunk_merge.rs. They name the corgi-backed implementation and what it's tested on.Corgiprefix. A follow-up could rename the ones that name a role rather than corgi-valued data:CorgiChunk,CorgiContainer,CorgiChunker,CorgiDistributor;CorgiBackend,CorgiImport,CorgiPact,CorgiHalfJoin,CorgiJoinBackend,CorgiReduceBackend.runtime/mod.rs's header still reads "The corgi rendering substrate's internals". It describes the code, not the path.Checks:
cargo test -p interactive -p ddir-server.src/runtime/is mapped back tosrc/corgi/.authored/check.py --fixture --workers 4.git grep "crate::corgi\|interactive::corgi\|src/corgi"returns nothing.🤖 Generated with Claude Code
https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o