Repository navigation
Add end-to-end regression tests for Bzlmod override patches - #527
Closed
alex-the-third wants to merge 3 commits into
Closed
alex-the-third wants to merge 3 commits into
alex-the-third wants to merge 3 commits into
Conversation
Register repository targets under apparent and canonical names so override patch changes propagate to cquery consumers. Add query and cquery regressions for changed outputs, stable repeated hashes, and unaffected unrelated targets. Fixes Tinder#522.
alex-the-third
changed the title
Author
|
Fixed by #528 already. All regressions passing as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds query and cquery regression coverage for #522 against the upstream implementation from #528.
The tests change only a
single_version_overridepatch to a.txtfile and verify that:The patched dependency uses a local registry and archive. The diff contains only e2e tests, their fixture and documentation, and generated test entries.
Validated on Linux in WSL:
bazel test //...: all 67 test targets passed, including the three previously failing cquery cases.go test -count=1 ./...intools/firecracker: passed.