Repository navigation
Disabled Ghost's in-development tables in the Docker images - #489
Conversation
Ghost 6.69 creates in-development tables (app_installations, app_installation_manifests) when NODE_ENV=development, which is meant for working on Ghost itself. The images symlink config.development.json to config.production.json, so setting createInDevelopmentTables: false there covers both modes. - 6: set the flag in the generated config during the build, and bumped Ghost-CLI to 1.33.2 (its new default only applies during `ghost setup`, which the image skips via --no-setup) - 6-next: added the flag to the checked-in baseline config Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 3 remain after this review. WalkthroughProduction configuration files and image build steps now set Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The images configure the development-mode config with the flag set to false, and no repository-level overwrite was found. Runtime behavior and image builds remain unverified, so confirm them with normal validation. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Ghost 6.69 creates in-development tables (
app_installations,app_installation_manifests) whenNODE_ENV=development. They're meant for working on Ghost itself, but they also get created by the Docker images when they run in development mode.Both images symlink
config.development.jsontoconfig.production.json, so settingcreateInDevelopmentTables: falsethere disables the tables in both modes. Setting the env varcreateInDevelopmentTables=truestill turns them back on.6
config.production.jsonduring the build with a shortnode -e, which writes a real boolean.false, but only insideghost setup, which the image skips (--no-setup), so the bump alone isn't enough.6-next
config-next.json).Generated files were regenerated with
versions.shandapply-templates.sh. I haven't built the images locally.🤖 Generated with Claude Code