Skip to content

Disabled Ghost's in-development tables in the Docker images - #489

Merged
acburdine merged 1 commit into
masterfrom
claude/ghost-dev-tables-docker-467494
Oct 8, 2026
Merged

acburdine merged 1 commit into
masterfrom
claude/ghost-dev-tables-docker-467494

Conversation

@acburdine

Copy link
Copy Markdown
Member

Ghost 6.69 creates in-development tables (app_installations, app_installation_manifests) when NODE_ENV=development. They're meant for working on Ghost itself, but they also get created by the Docker images when they run in development mode.

Both images symlink config.development.json to config.production.json, so setting createInDevelopmentTables: false there disables the tables in both modes. Setting the env var createInDevelopmentTables=true still turns them back on.

6

  • Sets the flag in the generated config.production.json during the build with a short node -e, which writes a real boolean.
  • Bumps Ghost-CLI to 1.33.2. That release defaults the flag to false, but only inside ghost setup, which the image skips (--no-setup), so the bump alone isn't enough.

6-next

  • Adds the flag to the checked-in baseline config (config-next.json).

Generated files were regenerated with versions.sh and apply-templates.sh. I haven't built the images locally.

🤖 Generated with Claude Code

Ghost 6.69 creates in-development tables (app_installations,
app_installation_manifests) when NODE_ENV=development, which is meant for
working on Ghost itself. The images symlink config.development.json to
config.production.json, so setting createInDevelopmentTables: false there
covers both modes.

- 6: set the flag in the generated config during the build, and bumped
  Ghost-CLI to 1.33.2 (its new default only applies during `ghost setup`,
  which the image skips via --no-setup)
- 6-next: added the flag to the checked-in baseline config

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5ceae6f1-1b3d-4140-b6bd-aba6bbfd9fbf
📥 Commits

Reviewing files that changed from the base of the PR and between 47832d2 and a8ceb55.

📒 Files selected for processing (7)
  • 6-next/alpine3.23/config.production.json
  • 6-next/bookworm/config.production.json
  • 6/alpine3.23/Dockerfile
  • 6/bookworm/Dockerfile
  • Dockerfile.template
  • config-next.json
  • versions.json

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 3 remain after this review.


Walkthrough

Production configuration files and image build steps now set createInDevelopmentTables to false. Ghost-CLI references change from version 1.33.1 to 1.33.2, with updated commit SHAs.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: ghost-slimer

Merge Risk: ⚪ Minimal · up to a8ceb

The images configure the development-mode config with the flag set to false, and no repository-level overwrite was found. Runtime behavior and image builds remain unverified, so confirm them with normal validation.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: disabling Ghost's in-development tables in Docker images.
Description check ✅ Passed The description directly explains the table behavior, configuration changes, Ghost-CLI update, and regeneration steps in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@acburdine
acburdine merged commit d4e32d7 into master Oct 8, 2026
9 checks passed
@acburdine
acburdine deleted the claude/ghost-dev-tables-docker-467494 branch October 8, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant