Skip to content

stack, corenetwork: fix: receiveSignal() overrides take intval_t, not long (macOS build) - #312

Closed
tabgab wants to merge 1 commit into
Unipisa:masterfrom
tabgab:fix/macos-receivesignal-intval
Closed

tabgab wants to merge 1 commit into
Unipisa:masterfrom
tabgab:fix/macos-receivesignal-intval

Conversation

@tabgab

@tabgab tabgab commented Nov 6, 2026

Copy link
Copy Markdown

Simu5G master (00e314c) does not build on macOS with OMNeT++ 6.5.0 and INET 4.7.0 (Apple clang):

./simu5g/corenetwork/coreControl/CoreControl.h:111:124: error: non-virtual member function marked 'override' hides virtual member functions
clistener.h:198: note: hidden overloaded virtual function 'omnetpp::cListener::receiveSignal' declared here: type mismatch at 3rd parameter ('intval_t' (aka 'long long') vs 'long')

The same error occurs in D2dBinder.h and in the D2dAmc.h mixin. The D2dAmc failure then cascades into LteAmcD2D and NrAmcD2D (Define_Module and getNrMcsTableForDirection errors).

cListener::receiveSignal() takes intval_t, which is int64_t. On Linux int64_t is long, so the overrides compile there and CI passes. On macOS it is long long, so a long parameter does not override the virtual function.

This PR declares the parameter as intval_t in the five places (CoreControl.h/.cc, D2dBinder.h/.cc, D2dAmc.h). It does not change behavior. With the change, release and debug build on macOS, and showcases/nr/standalone (-c Standalone) runs to the end.

… long (macOS build)

cListener::receiveSignal() takes intval_t (int64_t). On macOS int64_t is
'long long', so the overrides declared with 'long' in CoreControl, D2dBinder
and the D2dAmc mixin override nothing and clang rejects them ('non-virtual
member function marked override hides virtual member functions'); the D2dAmc
failure cascades into LteAmcD2D and NrAmcD2D. On Linux int64_t is 'long',
which is why CI does not see it. No behavior change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant