[TS] Make empty strings falsy in symbolic conditions - #456
Open
CaelmBleidd wants to merge 5 commits into
Open
CaelmBleidd wants to merge 5 commits into
CaelmBleidd wants to merge 5 commits into
Conversation
CaelmBleidd
marked this pull request as ready for review
October 2, 2026 21:36
CaelmBleidd
marked this pull request as draft
October 2, 2026 22:18
CaelmBleidd
force-pushed
the
caelmbleidd/ts-423-string-truthiness
branch
from
October 2, 2026 22:25
38041dd to
b57c27f
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/ts-421-symbolic-string
to
caelmbleidd/ts-422-string-value-equality
October 2, 2026 22:25
CaelmBleidd
force-pushed
the
caelmbleidd/ts-422-string-value-equality
branch
from
October 3, 2026 05:21
7927e93 to
127ecb5
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/ts-423-string-truthiness
branch
from
October 3, 2026 05:26
2c08f04 to
9d511c1
Compare
CaelmBleidd
marked this pull request as ready for review
October 3, 2026 06:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #423.
Stack
This PR is scoped to #423 and targets #455 / #422 at
127ecb5df35366c550a32725cf4e6af25208f673. Its head isdf0b9afe4b6730b9e88a466c796fd7989b539b9a(four linear commits, no merge commit).Change
stringand string-literal fields with UTF-16 backing. Preserve written values and mark values beyond the configured bound explicitly unsupported.Verification
TsDynamicTruthinessTestchecks that unbacked strings throughanyare recorded as unsupported. A source-leveltypeof value === "object" && value !== nullguard forces a nonstring reference throughif (value); the test requires aTsClasswitness with result1and replays it in Node.js. An unrelated outer false branch produces an unbacked-string witness that the test resolver cannot render; the test requires and classifies this separately, without counting it as supported. The typed-object path is checked independently.b5e10a1a0c5d279492c373caf907f6387fff998f, the previous head1c820b5apassed./gradlew :usvm-ts:test :usvm-ts:detektMain :usvm-ts:detektTest -PuseLocalJacodb=/private/tmp/jacodb-ts-398-build --offline --no-daemon --console=plain --quiet: 1,110 tests, 143 skipped, 0 failures/errors, and both Detekt tasks succeeded. The final commit changes only the assertion for classified unsupported witnesses; its focusedTsDynamicTruthinessTestanddetektTestpassed, including a forced rerun of the focused test.git diff --checkpassed.These are local results. Pinned core correctness and AI code hygiene my-review passes on final head
df0b9afefound no actionable defects. GitHub reports no automatic checks for this stacked PR; the final #460 stack runs manual CI separately.Boundary
The source-level
Boolean(input.value)call stops at unknown-call resolution (POINTER_TARGET_NOT_FOUND) before truthiness conversion. This PR covers directly executed condition operators.