Repository navigation
Add test_configuration to SameSimTestSuite to fix --export-json (fixes #1138) - #1230
Open
mustafacicek-eee wants to merge 1 commit into
Open
mustafacicek-eee wants to merge 1 commit into
mustafacicek-eee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1138.
When exporting tests to JSON using
--export-json,_main_export_json()iterates over all test suites and accessestest_suite.test_configurationto retrieve the test configuration mapping for each test case:When testbenches specify
-- vunit: run_all_in_same_sim, tests are grouped into aSameSimTestSuiterather thanTestSuiteWrapper.SameSimTestSuitedefinestest_namesandtest_information, but was missing thetest_configurationproperty, resulting in:Solution
test_configurationproperty toSameSimTestSuiteinvunit/test/suites.py, returning a dictionary mapping each full test name toself._configuration(mirroringtest_information).test_export_json_same_simintests/unit/test_ui.pyto test--export-jsonon testbenches withsame_sim=True.docs/news.d/1138.bugfix.rst.Verification
Ran the unit test suite:
test_export_jsonpassed.test_export_json_same_simpassed.