Conversation
…s and config Test fixtures, code comments and examples referenced real customer orgs, products and assistant names (an org slug, a product fleet, an assistant first name, a credential name) plus identifiers copied from live resources. Replace them with generic names and obviously fake ids so the public template carries no customer references. Slug shapes are preserved: suffixes stay 8 lowercase hex chars and each <name>-<suffix> slug still matches the first 8 chars of its UUID, so the slug, audit, recanonicalize and pull tests keep checking the same behavior. Docs, improvements.md and CLAUDE.md are left for a separate decision. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Test fixtures, code comments,
.gitignoreand the README onmainreference real customers: an org slug used as a credential and env-file example, a customer product name used as assistant and squad slugs, an assistant first name from a customer incident, a healthcare-looking assistant slug quoted from a live API error, and several UUIDs and 8-char suffixes copied from live resources. This is a public template, so none of that should be in the repo.Spotted while reviewing the PR 57 stack (#57). That stack only re-indents the affected test files, so the names showed up in its diff but were not introduced by it. The fix goes to
maindirectly instead of into the stack.What changes
acme,support,triage-bot,taylor,intake-stage-1,billing-end-call).d3adb33f-0000-4000-8000-000000000000,1a2b3c4d,0a1b2c3d,9f8e7d6c,7c6d5e4f,5e6f7a8b).Slug shapes are preserved: suffixes stay exactly 8 lowercase hex and each
<name>-<suffix>slug still matches the first 8 chars of its UUID, so the slug, audit, recanonicalize and pull tests exercise the same paths.Not in this PR
docs/learnings/*,improvements.md,CLAUDE.mdand.conductor/setup.shstill name customer forks (33 lines). Those are process and history references and need a separate call on wording.Testing
npx tsc --noEmit: clean.npm test: 355 pass, 0 fail (withnode_modulesinstalled in the worktree).src/,tests/, config and README returns nothing.🤖 Generated with Claude Code