ci: validate every org's resources on every pull request - #76
Open
scott-lowe-vapi wants to merge 1 commit into
Open
scott-lowe-vapi wants to merge 1 commit into
scott-lowe-vapi wants to merge 1 commit into
Conversation
Nothing ran `npm run validate` before merge. A config that `apply` refuses (name length, structured-output lockstep, duplicated prompts, the maxTokens floor, voice schema) could merge green, and deploys and promotion out of main then stopped until a fix landed. Plain `push` only warns, and can fail partway with an API 400. - ci.yml gets a Validate resources job: validate for every folder under resources/, reporting every failing org rather than stopping at the first. validate makes no network call; the engine's config only needs a key to be set, so the step sets a placeholder that is never sent. The job has no secrets, so forks get it too. No engine change. - tests/ci-validate-workflow.test.ts runs the step itself against fixture orgs: no orgs, all valid, one invalid org among valid ones, an invalid folder name, and no secrets or persisted credentials. - README, AGENTS.md (change loop), the workflows, PR checks and troubleshooting guides, and improvements.md #37 describe it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Oct 3, 2026
Contributor
Author
scott-lowe-vapi
marked this pull request as ready for review
October 3, 2026 07:29
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Value
V.A.L.U.E. tier: small — touches
.github/workflows/(a blast-radius path), and changes what customer forks see on their pull requests.npm run validatebefore merge.apply, and so promotion, refuses to deploy a config with validation errors: a name over 40 characters, structured-output lockstep, duplicated prompts, themaxTokensfloor, or the voice schema. That refusal came after merge:mainheld a config that wouldn't deploy, and promotion stopped until someone opened a fix PR. Plainpushonly warns, then can fail partway with an API 400. Each rule in the validator comes from a real mid-push failure (improvements.mdmembersOverrides.artifactPlan.structuredOutputIds is requiring UUID #8, Specifying handoff tools in a squad requires UUID to function correctly #9, fix(call): clear wrapped partial transcripts cleanly in npm run call #11, feat: simulation suite runner (npm run sim) #18, refactor: state schema with per-resource content hashes #19).main.ci.ymlrunsvalidatefor every folder underresources/on every pull request. It reports every failing org rather than stopping at the first.validatemakes no network call; loading the engine's config only requires a key to be set, so the step sets a placeholder that is never sent. The job has no secrets, so it runs the same on forks and Dependabot PRs.ci.yml, not the PR check workflow, so every fork gets it without turning on PR checks. On this template, which has no org folders, it does nothing.AGENTS.mdchange loop: if the check fails, fix the errors and don't weaken the check;improvements.mdAdd GitOps Support for Pronunciation Dictionaries with Versioned Updates #37.Heads-up for forks: plain
pushonly warned about these errors, so a repo may already carry some. The first PR after this lands will show them, whatever it changes. The troubleshooting guide covers it.applyalready refused those configs, so this moves an existing failure earlier rather than adding a new one.Evidence of value
tests/ci-validate-workflow.test.tsruns the job's real step, read fromci.yml, against copies of the starter example:Mutation: making the loop ignore
validate's exit code fails the two failure-case tests.Testing plan
npm test(514 tests) andnpx tsc --noEmitpass.applyalready runs it on every deploy.Refs TEST-141
🤖 Generated with Claude Code