Skip to content

Fix 26.3 enchantment registry backporting to 26.2 - #1346

Open
KurosawaTomoya wants to merge 1 commit into
ViaVersion:masterfrom
KurosawaTomoya:fix/26.3-to-26.2-enchantment-registry
Open

KurosawaTomoya wants to merge 1 commit into
ViaVersion:masterfrom
KurosawaTomoya:fix/26.3-to-26.2-enchantment-registry

Conversation

@KurosawaTomoya

Copy link
Copy Markdown
  • Properly remove the 'type' field when renaming it to 'condition' for enchantments.
  • Wrap inline CompoundTag terms inside 'all_of'/'any_of' conditions into a ListTag.
  • Map the new 'int_value_check' and 'float_value_check' conditions back to 'value_check' and rename the 'test' field back to 'range'.

- Properly remove the 'type' field when renaming it to 'condition' for enchantments.
- Wrap inline CompoundTag terms inside 'all_of'/'any_of' conditions into a ListTag.
- Map the new 'int_value_check' and 'float_value_check' conditions back to 'value_check' and rename the 'test' field back to 'range'.
@KurosawaTomoya

Copy link
Copy Markdown
Author

Just checking in on this PR. Whenever you have time, I'd appreciate a review. Thank you!

Explanation

This PR fixes the registry parsing errors affecting Stellarity enchantments on Minecraft 26.2.

When connecting to a Leaf server, the client fails to parse the following enchantments during registry loading:

  • stellarity:ambush
  • stellarity:critical_strike
  • stellarity:void_shot

This causes the client to fail while processing the clientbound/minecraft:finish_configuration packet, resulting in a registry loading error and disconnect.

The issue is caused by the enchantment data being incompatible with the Minecraft 26.2 registry format.

This PR updates the affected enchantment definitions to the correct format for Minecraft 26.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant