Repository navigation
Fix Xaero's world map being transparent - #98
Conversation
|
Hey, thank you for PR! Did you test on older versions like 1.21.1, 1.20.1? I noticed that this does not have stonecutter logic excluding versions that don't have an issue from mixin. Im worried it might create issues for older versions |
Not yet, I didn't have time because it was taking too long to build, I will test them as soon as I get the chance |
|
@Phoenix-Ra Tested on forge 1.20.1 and it does exactly what I expected, nothing. It's why I didn't add stonecutter logic, all the fix does is add a black background to the world map. If it doesn't need it it just adds a black background that changes nothing visually, if it does need it it adds a background that does fix it. Also means it will work on any minecraft version that might have broken without it going forwards, including older versions too. |
|
Alright, I started the workflow to build for all versions then make sure its fine and if all good - merge |
Adds an opaque background behind the map as it copies its background's opacity.