pdfjs: Reset canvas_logs in tearDownPdfJS and call validate (#289) - #320
Open
camillobruni wants to merge 1 commit into
Open
camillobruni wants to merge 1 commit into
camillobruni wants to merge 1 commit into
Conversation
Reset the canvas_logs array in tearDownPdfJS to prevent accumulating logs across benchmark runs. Hook up validate() on class Benchmark so tearDownPdfJS() is executed at the end of the benchmark run to verify rendering output and allow GC of the canvas logs and global PDFJS state. Fixes WebKit#289
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Contributor
This looks like noise to me. No objections to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the
canvas_logsarray intearDownPdfJSto prevent accumulating logs across benchmark runs. Hook upvalidate()onclass BenchmarksotearDownPdfJS()is executed at the end of the benchmark run to verify rendering output and allow GC of the canvas logs and global PDFJS state.Fixes #289