Repository navigation
feat: GeoIP database card and missing-database alert - #1903
Merged
Merged
Conversation
…cover the file operations
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1894
What changes
Missing database no longer locks anyone out. When no GeoIP database is available, country access lists are not enforced (an allow-list lets everyone in, a block-list blocks no one). Other protections on the host are unaffected. This replaces the temporary behaviour that refused every address except the admin whitelist.
A red alert in the notification bell reports it until the database is back. It is shown in the app only, cannot be dismissed, clears by itself, links to a troubleshooting page and suggests opening an issue, since the database is normally included. The alerts come from a new
GET /notifications/alertsendpoint computed from the last applied proxy config.A Country database card on the Security page (admins only):
POST /access-lists/self-check)The new upload and remove routes are admin-only, audited, refuse cross-origin browser requests, and never put file paths in error bodies. The bundled copy under
/app/geoipis never modified, and backups do not include the data-folder copy.Reload now applies the proxy config even when the database fails to load, so the proxy, the status and the alert agree.
Translations for the new text are in all 28 locales; the non-English ones are drafts that would benefit from a native-speaker pass.
Validation
make lint-backend, frontend lint/type-check/build, lefthook, CodeQL Go/JS and Trivy are clean apart from items already suppressed.docs/reports/qa_report.md.