Repository navigation
fix(build): quote the bundle's externals so Windows builds them - #777
Merged
Merged
Conversation
pnpm runs scripts through cmd.exe on Windows, which keeps single quotes: --external '@mtcute/*' reached cli-dev as "'@mtcute/*'", matched nothing, and the release's Windows job failed. Double quotes are removed by both sh and Windows argv parsing. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Unblock the 0.103.0 release: its Windows job failed in
pnpm build(run).Why
pnpm runs scripts through
cmd.exeon Windows, which keeps single quotes, so--external '@mtcute/*'reachedcli-dev bundleas'@mtcute/*'. It matched nothing, mtcute was bundled, and the build refused it. Double quotes are removed by sh and by Windows argv parsing alike.What
build:--external "@mtcute/*"instead of'@mtcute/*'. Nothing else changes.Testing
pnpm buildon Linux; the fullci.ymlwith platforms dispatched on this branch (Windows, macOS).🤖 Generated with Claude Code