Skip to content

833: fix missing opening square bracket on unicode character set - #864

Merged
lindsay-stevens merged 1 commit into
XLSForm:masterfrom
lindsay-stevens:pyxform-833
Oct 1, 2026
Merged

lindsay-stevens merged 1 commit into
XLSForm:masterfrom
lindsay-stevens:pyxform-833

Conversation

@lindsay-stevens

Copy link
Copy Markdown
Contributor

Closes #833

  • test case includes characters in the broken range as an example (the test fails without the fix). The intent of the regex is to match XML so it should have allowed them.
  • not quite a regression since although the typo has been present since 2024, the previous regex validation only allowed ascii characters. Also the error message just says "letters" are allowed rather than specifying that a particular type of letter is supported.

Why is this the best possible solution? Were any other approaches considered?

I think this is the only way to fix it? There is the option to only allow ASCII letters but that seems unnecessarily restrictive.

What are the regression risks?

Fixes a bug.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

N/A

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyxform tests and ruff check pyxform tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

- test case includes characters in the broken range as an example. The
  intent of the regex is to match XML so it should have allowed them.
- not quite a regression since although typo has been present since
  2024, the previous regex validation only allowed ascii characters.
  Also the error message just says "letters" are allowed rather than
  specifying that a particular type of letter is supported.

@lognaturel lognaturel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lindsay-stevens
lindsay-stevens merged commit 5dc3a39 into XLSForm:master Oct 1, 2026
14 checks passed
@lindsay-stevens
lindsay-stevens deleted the pyxform-833 branch October 1, 2026 03:23
@lindsay-stevens lindsay-stevens mentioned this pull request Oct 1, 2026
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid question name 'SäöüÄÖÜß'

2 participants