Repository navigation
534: Require labels for items in choice lists - #875
Open
lindsay-stevens wants to merge 2 commits into
Open
lindsay-stevens wants to merge 2 commits into
lindsay-stevens wants to merge 2 commits into
Conversation
- previously showed a pyxform warning for no label, then an ODK validate error; now there's a pyxform error for no label and media.
- in clean_text_values, skip regex if the maybe_strip result is empty - for PyXFormErrors using ErrorCode, use the code/context pattern instead of pre-formatting the message string (used for warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #534
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue.
What are the regression risks?
Forms that ignored the warning and did not use Validate, will now be rejected by pyxform.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No, the docs don't tend to explicitly say which columns are required and don't say that a label is optional, but example forms and the template consistently show choices with a label of some kind. In the XForms 1.0 XSD a
labelis required for a choicesitem.Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code