Skip to content

Fix Copy Path pasteboard contents so the path can be pasted into Terminal #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monsterlag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Copy Path pasteboard contents so the path can be pasted into Terminal #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Xcodes/Backend/AppState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,12 +825,16 @@ class AppState: ObservableObject {
}
}

func copyPath(xcode: Xcode) {
func copyPath(xcode: Xcode, pasteboard: NSPasteboard = .general) {
guard let installedXcodePath = xcode.installedPath else { return }

NSPasteboard.general.declareTypes([.URL, .string], owner: nil)
NSPasteboard.general.writeObjects([installedXcodePath.url as NSURL])
NSPasteboard.general.setString(installedXcodePath.string, forType: .string)
// Write a single item with real data for each type. Declaring `.URL` without
// providing data left an empty first item that Terminal and other apps couldn't paste.
let item = NSPasteboardItem()
item.setString(installedXcodePath.url.absoluteString, forType: .fileURL)
item.setString(installedXcodePath.string, forType: .string)
pasteboard.clearContents()
pasteboard.writeObjects([item])
}

func copyReleaseNote(from url: URL?) {
Expand Down
15 changes: 15 additions & 0 deletions XcodesTests/AppStateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,21 @@ class AppStateTests: XCTestCase {
subject = AppState()
}

func test_CopyPath_WritesOneItemWithPathAndFileURL() throws {
let installedPath = try XCTUnwrap(Path("/Applications/Xcode 26.0.app"))
let xcode = Xcode(version: Version("26.0.0")!, installState: .installed(installedPath), selected: false, icon: nil)
let pasteboard = NSPasteboard(name: NSPasteboard.Name("AppStateTests-\(UUID().uuidString)"))
defer { pasteboard.releaseGlobally() }

subject.copyPath(xcode: xcode, pasteboard: pasteboard)

let items = try XCTUnwrap(pasteboard.pasteboardItems)
XCTAssertEqual(items.count, 1)
XCTAssertEqual(items.first?.types, [.fileURL, .string])
XCTAssertEqual(items.first?.string(forType: .string), "/Applications/Xcode 26.0.app")
XCTAssertEqual(items.first?.string(forType: .fileURL), "file:///Applications/Xcode%2026.0.app")
}

func test_InstallError_Network401IsUnauthorized() {
let error = NetworkError.non200StatusCode(statusCode: 401, data: Data())

Expand Down