Repository navigation
35-smooth-outline: review fixes - #10
Merged
Merged
Conversation
…rve (was dead code), sampling refined at small radii, shared fit pipeline, stronger offset tests Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01EufyFxY5SRQuikTThXFFEU
…ntle runs, exact bbox), tasks 1.5 and 4.2 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
Перепроверка change 35 (
35-smooth-outline) против proposal/design/spec/tasks.Найдено и исправлено
offsetCurve(задача 1.2) нигде не вызывался, хотя CHANGELOG утверждал, что зазор смещает кривую. ТеперьpocketSolidдля контуров используетoffsetCurve(скругление выпуклых углов, митра вогнутых), при самопересечении или обходе по часовой стрелке откатывается на смещение ядра.sampleCurvesне измельчал шаг при малом радиусе (design: шаг ≤ √(8·R·0.03)). Добавлено.fitOutlineиfittedVertexCountдублировали конвейер; теперь общийfitCurves.Тесты
offsetCurve: ни одна точка смещённого контура не ближе зазора к исходному, дуга на остром углу, контур по часовой стрелке.npm test(2061) иnpm run buildзелёные.Не сделано
[ ]: фото и браузерная проверка здесь недоступны. Change не архивирован.Generated by Claude Code