Skip to content

Sync independent sites permissions, sidebar layouts and Personal Agent fixes - #229

Merged
Luhaozhu merged 1 commit into
mainfrom
sync/ce-20261113-sites-navigation
Nov 14, 2026
Merged

Luhaozhu merged 1 commit into
mainfrom
sync/ce-20261113-sites-navigation

Conversation

@Luhaozhu

@Luhaozhu Luhaozhu commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Purpose and behavior

  • Before: Sites followed the lab permission, sidebar module placement was fixed, and Personal Agent messages could disappear briefly after sending or disrupt history reading.
  • After: Sites have an independent server-enforced permission, modern and classic sidebar layouts use separate module placement, and Personal Agent keeps sent messages visible and follows new content unless the reader scrolls up. Legacy memory instructions are refreshed and MCP guidance includes only actual handshake instructions.

Change walkthrough

  • Flow: src/backend/features/sites/permission.py gates management and agent callbacks through core/auth/capabilities.py. Migration ce_0046_sites_permission.py copies existing personal lab settings without overwriting explicit site settings. src/frontend/src/utils/pageConfigDefaults.ts normalizes layout configuration consumed by components/sidebar/moduleNavigation.ts. Personal Agent conversation and memory changes reach their existing UI and workspace consumers.
  • Decisions: This is a generated CE sync. Organization permission stores and the organization-only migration test are removed by upstream derivation; CE retains its own personal migration. Public-only review instructions, PR template and review-context workflow are preserved. No private runbooks or enterprise routes are included.

Risk and compatibility

  • Risk: high
  • Boundaries: Site authorization and upgrade behavior need review. Public site hosting remains accessible. Existing explicit site settings are preserved. Module configuration cannot introduce arbitrary applications into navigation. Memory refresh preserves custom instructions outside recognized obsolete passages.
  • Human review: A maintainer must assess permission defaults, upgrade behavior, navigation compatibility and memory rewrite boundaries before merging. No human approval is claimed.

Verification

  • Evidence: CE derivation passed boundary, brand, binary asset and license gates, import/OpenAPI/ORM checks and CE release regression tests. CE site tests: 5 passed; memory and MCP tests: 20 passed. Navigation model test and CE production frontend build passed. PR-context tests: 19 passed. Upstream integration tests: 47 passed. git diff --check passed.
  • Limits: The sidebar browser fixture stalled before its application initialization; the same test with pre-update frontend sources reproduced the same timeout, so it is not counted as passed. Full upstream frontend lint reported 245 errors and 20 warnings. All 23 errors in changed TypeScript files were reproduced on the pre-update versions of those files; no clean lint result is claimed. This PR does not establish installed desktop upgrade behavior.

Recovery

  • Steps: Revert the sync commit and restore the previous application build. The additive sites permission can remain because older code ignores it. Restore a pre-upgrade database/workspace backup if data-level rollback is required; a code revert alone does not restore rewritten memory instructions.

Review follow-up

  • Disposition: Initial maintainer review is pending. CE derivation was repaired upstream to exclude organization stores and preserve existing personal site access.

Community checklist

  • This is an allowed contribution or a maintainer-reviewed generated sync.
  • Public bilingual documentation is updated in both languages where applicable.
  • Links/code snippets were checked and CONTRIBUTING.md was read.

@Luhaozhu
Luhaozhu merged commit 4ff6d40 into main Nov 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant