Repository navigation
UN-4271 [FEAT] Frontend v1 version switch and route registry #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a5fbc98
feat(frontend-v1): version switch and route registry (UN-4271)
jaseemjaskp e62aec1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 217c586
fix(frontend-v1): address self-review of the version switch (UN-4271)
jaseemjaskp 3a8c300
fix(frontend-v1): reject same-page route overlaps, encode demo links …
jaseemjaskp e482e2a
Merge remote-tracking branch 'origin/main' into UN-4271-version-switc…
jaseemjaskp 0c83ab8
feat(v1): mount the Toaster in the v1 root
jaseemjaskp e798148
fix(frontend-v1): address review of the version switch (UN-4271)
jaseemjaskp 7969ce1
Merge branch 'main' into UN-4271-version-switch-route-registry
jaseemjaskp 850ebfa
fix(frontend-v1): address the version switch review (UN-4271)
jaseemjaskp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * The v1 tree: its own providers and routes, never inside a v0 layout or | ||
| * guard. Loaded lazily by the version switch, so v1's code reaches the | ||
| * browser only when a v1 page renders; its styles are in the global | ||
| * stylesheet (vite.config.js sets cssCodeSplit: false). The Toaster mounts | ||
| * here, once, so `notify()` reaches the user on every v1 page. Session, | ||
| * guards (P0-T06) and the shell (P2-T01) mount here. | ||
| */ | ||
|
|
||
| import type { RegistryEntry } from "@v1/app/registry/types"; | ||
| import { ThemeProvider } from "@v1/app/theme/ThemeProvider"; | ||
| import { Toaster } from "@v1/components/ui/feedback"; | ||
| import { type JSX, Suspense } from "react"; | ||
| import { Route, Routes } from "react-router-dom"; | ||
| import { PAGE_COMPONENTS } from "./pages"; | ||
|
|
||
| export type V1AppProps = Readonly<{ entry: RegistryEntry }>; | ||
|
|
||
| export function V1App({ entry }: V1AppProps): JSX.Element { | ||
| const Page = PAGE_COMPONENTS[entry.page]; | ||
| if (!Page) { | ||
| throw new Error(`v1 page ${entry.page} is registered but has no component`); | ||
| } | ||
| return ( | ||
| <ThemeProvider> | ||
| <Suspense fallback={null}> | ||
| <Routes> | ||
| {entry.v1Routes.map((path) => ( | ||
| <Route key={path} path={path} element={<Page />} /> | ||
| ))} | ||
| </Routes> | ||
| </Suspense> | ||
| <Toaster /> | ||
| </ThemeProvider> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.