Repository navigation
docs: record algebraic floating-point rejection - #281
Merged
Merged
Conversation
- Retain strict arithmetic after the norm reduction prototype hid required overflow errors despite local timing gains. - Preserve the numerical counterexample, measurements, provenance, and reproducible experimental evidence. - Map floating-point, certified, interval, and exact arithmetic contracts to validation evidence and record closure of the remaining prototype work. - Update documentation navigation, release planning, and the reviewed README link inventory. Closes #250
acgetchell
enabled auto-merge (squash)
October 15, 2026 17:34
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title is concise and accurately summarizes the primary change: documenting the rejection of algebraic floating-point operations and retaining strict arithmetic. |
| Linked Issues check | |
Issue #250 is closed and provides historical context only. No active directly linked target remains, so this pull request has no active linked-issue coding requirements. The documented retain-strict d… |
| Out of Scope Changes check | |
The changed files remain within the documented scope of recording the #250 evaluation. The study archive, validation records, mathematical basis, navigation, roadmap, and README release-link rule supp… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 14 14
Lines 7160 7160
=======================================
Hits 7027 7027
Misses 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #250 evaluation found that an algebraic
Matrix::norm_infreduction could returnf64::MAXwhere strict accumulation must reportLaError::NonFinite. This PR records the decision to reject algebraic floating-point operations and retain the existing arithmetic model.docs/archive/performance/studies/.docs/validation/records connecting strictf64, certified bounds, intervals, exact arithmetic, and conversion contracts to their evidence.The prototype improved local D=4/5 timings by about 22–25% and D=8 by 39–40%, while D=2/3 regressed. Those measurements describe a rejected prototype, not a correctness-preserving optimization. No library behavior changes. Native Linux/Windows prototype execution was not performed; the records distinguish cross-compilation from native validation and document the maintainer's decision to end that work.
Validation: full
just cipassed, including 141 Python tests, 1,002 Rust tests, default/exact doctests, static checks, benchmark compilation, and examples. The archived report also passed explicit Markdown/spelling checks, and all 40 retained Criterion measurements were checked for 100 valid samples. The local full CI run needed to run outside the sandbox because the TOML formatter's macOS system-configuration access crashed inside it.Closes #250, already closed with the recorded negative decision.
Summary by CodeRabbit