Repository navigation
Lay date-range filters out with flexbox so long labels don't wrap the inputs - #70
Merged
Merged
Conversation
… inputs The date-only range filter (two input.datepicker fields) gets no width from the base CSS, so the inputs relied on their size=12 intrinsic width and only lined up by luck; the label's float:right 'Set range' link leaked into the input band on a longer label and pushed the 'To' field onto a second line. Flexbox lays the label on its own row and lets the two inputs share the next, immune to the float. Consumers previously each carried their own fix (one with flexbox, one with calc widths + !important); this owns it for all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The date-only range filter (two
input.datepickerfields) gets no width from the base CSS, so the inputs relied on theirsize=12intrinsic width and lined up side by side only by luck. The label'sfloat:right"Set range" link then leaked into the input band on a longer label (e.g. "Customer registration date") and bumped the "To" input onto a second line. Flexbox puts the label on its own row and lets the two inputs share the next, immune to the float. Apps that use this theme each carried their own version of this fix (one flexbox, onecalc()+!important); this moves it into the theme for all of them.