Skip to content

fix: add scrollbar gutter to style macro - #10682

Merged
yihuiliao merged 2 commits into
mainfrom
fix-chat-bug
Sep 30, 2026
Merged

yihuiliao merged 2 commits into
mainfrom
fix-chat-bug

Conversation

@yihuiliao

Copy link
Copy Markdown
Member

kept getting a maximum depth exceeded error after i merged main into this #10600 for one specific story (which is stashed so it's not actually on the PR). this is bc the scrollbar kept appearing and disappearing, affecting the layout.

turns out in https://github.com/adobe/react-spectrum/pull/10577/changes i had moved scrollbarGutter which was previously inline to the style macro but it's not supported there so it was silently failing. this PR adds scrollbarGutter to the style macro theme. if we do not want to support this, we can just add it back to GridList's inline styles.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at AGENTS.md.

📝 Test Instructions:

go to Chat stories and make sure scrollbarGutter: stable is applied to the GridList styles

🧢 Your Project:

@github-actions github-actions Bot added the S2 label Sep 30, 2026

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget if position in the object matters, might need to be added to the end

@rspbot

rspbot commented Sep 30, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 30, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (11)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/cc0d69a88392673879af810eac8d4916f9c6755e/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/cc0d69a88392673879af810eac8d4916f9c6755e/

@yihuiliao
yihuiliao added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 9675029 Sep 30, 2026
31 checks passed
@yihuiliao
yihuiliao deleted the fix-chat-bug branch September 30, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants