Repository navigation
fix: add scrollbar gutter to style macro - #10682
Merged
Merged
Conversation
snowystinger
approved these changes
Sep 30, 2026
snowystinger
left a comment
Member
There was a problem hiding this comment.
I forget if position in the object matters, might need to be added to the end
|
Build successful! 🎉 |
reidbarber
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kept getting a maximum depth exceeded error after i merged main into this #10600 for one specific story (which is stashed so it's not actually on the PR). this is bc the scrollbar kept appearing and disappearing, affecting the layout.
turns out in https://github.com/adobe/react-spectrum/pull/10577/changes i had moved
scrollbarGutterwhich was previously inline to the style macro but it's not supported there so it was silently failing. this PR addsscrollbarGutterto the style macro theme. if we do not want to support this, we can just add it back to GridList's inline styles.✅ Pull Request Checklist:
📝 Test Instructions:
go to Chat stories and make sure
scrollbarGutter: stableis applied to the GridList styles🧢 Your Project: