Repository navigation
fix: recover recorded paths for known subagents - #687
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small replay omission found while auditing the completed #655 extraction after #686 merged. All eight planned slices are already on
main; this is a narrowly scoped correctness follow-up, not another feature tranche.A legacy
spawnAgentrecord can establish a coordinator's identity and parent without an agent path. Later replay may supply that coordinator's path and newly recorded nested child activity. PreviouslyannounceHistoryreturned immediately for the known coordinator, discarding the available path. The nested activity then could not resolve its immediate parent, so valid descendant history was omitted with a gap advisory.Fill a known child's missing normalized path from recorded activity before descending into its history. Do not replace an already observed path with older history. Identities, established parent links, titles, runtime ownership, capabilities, AIR behavior, and v1/v2 negotiation remain unchanged.
2 files, +39/-1 lines. No snapshot changes.
Regression evidence
mainbefore the fix: a live or restored pathless coordinator prevented newly recovered descendant text from replaying.Validation
npm run typechecknpm test: 2,070 passed, 39 skippednpm run buildnpm run test:integration: 15 passed against real Codex 0.164.0 with a local mock Responses APInpm run bundle:all: all six targets compiledgit diff --checkThe full live-model E2E suite and an additional live-model smoke test were not run for this fix. Cross-platform bundles were compiled, not executed on each target OS.
Audit context
The remaining old #655 diff largely reflects replaced implementations, differently organized tests/snapshots, and intervening trunk work such as native model reporting. In particular its older queue-completion helper and model implementation must not replace the corrected trunk versions. The combined PR should not be merged wholesale.
Checked current specification revision
c0897908cb2305e89203218c348d69ab4acf9d61. This fix retains the RFD's truthful identity, parentage, and parent-before-child replay ordering; it adds no wire fields or mutation authority.