Repository navigation
Conversation
Move CR handling into an opt-in LineBuffer mode so CRLF lines within a chunk stay zero-copy and each byte is scanned once. Add regression tests for bare CR, mixed, and split CRLF line endings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSE permits CR, LF and CRLF line endings (specification). The parser currently splits only at LF, so a response framed with CR can wait indefinitely or be combined with the next event.
Recognize CR immediately and consume an optional following LF across chunks using the existing bounded line buffer.
Validation
npm test: 490 passed.Additional regression cases remain local, following the repository's instructions on tests and documentation.