Repository navigation
fix: exit 1 when scan --fail-on-risk or inventory could not read every path - #29
Merged
Merged
Conversation
…y path `scan --fail-on-risk` now exits 1 when the scan skipped a path it could not read or classify, in text and `--json`. Plain `scan` still exits 0. Before, a CI gate built on it passed on an incomplete scan. `inventory` still completes every mode (write, `--check`, `--stdout`) when paths were skipped, then lists them on stderr and exits 1. A mode that already failed keeps its own exit code. `optimize` keeps exit 2 for an unreadable path, since it refuses before any paid call. docs/exit-codes.md, scan, inventory, README and usage text now agree on these codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan --fail-on-risknow exits 1 when the scan skipped a path it could not read or classify, in text and--json. Plainscanstill exits 0. Before, a CI gate built on it passed on an incomplete scan.inventorystill completes every mode (write,--check,--stdout) when paths were skipped, then lists them on stderr and exits 1. A mode that already failed keeps its own exit code.optimizekeeps exit 2 for an unreadable path, since it refuses before any paid call.Closes #23