Skip to content

fix: link and reconcile reports no longer count records that failed to save - #30

Merged
llbbl merged 1 commit into
mainfrom
fix/unsaved-state-records
Oct 24, 2026
Merged

llbbl merged 1 commit into
mainfrom
fix/unsaved-state-records

Conversation

@llbbl

@llbbl llbbl commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • On a failed state save, link reports its links as created but NOT recorded, and the JSON recorded is empty.
  • link --undecline reports the markers as NOT cleared.
  • reconcile drops its adopted and declined records from the report and JSON.
  • reconcile --json gains prune_adopted.
  • The tests force the save failure with a path-length fixture; the new testfs.DirWithRoom helper, plus a fix for an off-by-one in probePath.

Test plan

  • just check passes
  • The new tests were mutation-checked
  • The path-length fixture was swept across temp-dir lengths on macOS and on Linux as root

Closes #24

…o save

- On a failed state save, link reports its links as created but NOT recorded, and the JSON `recorded` is empty.
- `link --undecline` reports the markers as NOT cleared.
- reconcile drops its adopted and declined records from the report and JSON.
- `reconcile --json` gains `prune_adopted`.
- The tests force the save failure with a path-length fixture; the new testfs.DirWithRoom helper, plus a fix for an off-by-one in probePath.
@llbbl

llbbl commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

link behavior improved a bit

@llbbl
llbbl merged commit 813ff6b into main Oct 24, 2026
2 checks passed
@llbbl
llbbl deleted the fix/unsaved-state-records branch October 24, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: link and reconcile reports no longer count records that failed to save

1 participant