Repository navigation
flight-cli: release tests miss an added publishing job outside the pypi - #311
Merged
Merged
Conversation
Mutate the shipped release workflow six ways (a third publishing job after or between the jobs, the publish step in the build job, id-token or environment pypi granted to another job, an inline password input) and require the trusted-publishing test to refuse each one. Unit: work-52t0l.7
The trusted-publishing test now splits the workflow into its jobs and requires that only the publish job uses the PyPI publish action, grants id-token and runs in environment pypi. Its password check also catches an inline with: mapping. Unit: work-52t0l.7
Unit: work-52t0l.7
ak2k
marked this pull request as ready for review
October 23, 2026 03:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release workflow edit that adds a publishing path outside the pypi environment now fails the repository tests instead of passing them.
Class: STANDARD
Gates:
03-oracle: green
04-review: ADVISORY
07-gate: skipped, review returned ADVISORY, no P2 or worse: the gate does not run
Commits: