Repository navigation
flight-cli: a broken pipe on the plain/fan-out calendar arms exits 120 - #315
Merged
Merged
Conversation
A child runs the entry point with stdout a pipe whose reader is gone; it must end with the code the command chose and no BrokenPipeError. A second test pins the memo sentence that describes the entry point's flush. Unit: work-h70kv.29
The flight entry point flushes stdout once the command returns or exits. When the reader has hung up, it points stdout at /dev/null, so CPython's final flush no longer fails and forces exit 120 with a BrokenPipeError on stderr. Any other failed write, such as a full disk, is left for CPython to report at exit as before. Unit: work-h70kv.29
A process started with fd 1 closed has sys.stdout set to None, so the entry point's stdout flush raised AttributeError in its finally and turned every exit code into 1. The flush now skips a missing stream, as CPython does at exit. Unit: work-h70kv.29 Fixes-unit: work-h70kv.29
ak2k
marked this pull request as ready for review
October 26, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piping a flight command into head or another reader that hangs up now ends with the exit code the command chose, not CPython's stray 120, and no BrokenPipeError traceback.
Class: STANDARD
Gates:
03-oracle: green
04-review: FINDINGS
06-oracle: green
07-gate: AGREEMENT_CLEAN
Commits: