Repository navigation
fix: 🐛 drop denied Store capabilities and guard moves into AppData - #44
Merged
Merged
Conversation
Partner Center denied allowElevation and unvirtualizedResources. Neither is needed: the link helper's runas launch shows UAC without allowElevation, and mklink runs in cmd.exe, which writes to the real AppData. build-msix.ps1 now fails if the package declares anything besides runFullTrust. Co-Authored-By: Claude Opus 5.5 <[email protected]>
In the MSIX package, new files and folders Symlinker creates under AppData go to the package's private copy, so a move into AppData would leave the link pointing at an empty folder. The Store version now shows a message and stops before anything changes. Moving out of AppData and linking into AppData without moving still work. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partner Center denied the
allowElevationandunvirtualizedResourcescapabilities in the first Store submission. This drops both, so the package only declaresrunFullTrust. It also adds a guard for the one case that would break withoutunvirtualizedResources: moving files into AppData.Why the capabilities aren't needed
Tested on the installed package with Developer Mode off:
runasand Windows shows the usual UAC prompt. One prompt, the symbolic link is created.cmd.exe, a child process, which writes to the real AppData. Links into AppData land in the right place.What still breaks: moving into AppData
New files and folders that Symlinker's own process creates under AppData go to the package's private copy (
%LOCALAPPDATA%\Packages\<PFN>\LocalCache). A move into AppData would leave the link pointing at a folder only Symlinker can see, and uninstalling would delete the data.So in the Store version,
LinkCreatornow refuses to move into AppData:Elevation.IsPackaged()checksGetCurrentPackageFullNameto see whether the process runs from a packageMoveIntoAppDataUnsupportedin all 9 languagesOther changes
build-msix.ps1fails if the package declares any capability besidesrunFullTrustrunFullTrustrunFullTrustis needed, and the AppData limitation under Known LimitationsTests
IsPackaged_IsFalse_OutsideAnMsixPackageMove_IntoAppData_IsRefused_InTheStorePackageMove_OutOfAppData_Works_InTheStorePackageMove_IntoAppData_Works_OutsideTheStorePackageLocally: 176 tests, 173 passed, 3 skipped (symbolic link tests need Developer Mode). CI runs elevated, so it covers those and the coverage gate.
After merging
v4.3.1(the v4.3.0 bundle still declares the denied capabilities)🤖 Generated with Claude Code