Skip to content

fix: 🐛 drop denied Store capabilities and guard moves into AppData - #44

Merged
amd989 merged 2 commits into
masterfrom
fix/store-capabilities
Nov 16, 2026
Merged

amd989 merged 2 commits into
masterfrom
fix/store-capabilities

Conversation

@amd989

@amd989 amd989 commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Summary

Partner Center denied the allowElevation and unvirtualizedResources capabilities in the first Store submission. This drops both, so the package only declares runFullTrust. It also adds a guard for the one case that would break without unvirtualizedResources: moving files into AppData.

Why the capabilities aren't needed

Tested on the installed package with Developer Mode off:

  • allowElevation: the link helper starts with runas and Windows shows the usual UAC prompt. One prompt, the symbolic link is created.
  • unvirtualizedResources: mklink runs in cmd.exe, a child process, which writes to the real AppData. Links into AppData land in the right place.
  • A move-and-link out of AppData across drives (including the staging rename) works, because renames and deletes of existing items aren't redirected.

What still breaks: moving into AppData

New files and folders that Symlinker's own process creates under AppData go to the package's private copy (%LOCALAPPDATA%\Packages\<PFN>\LocalCache). A move into AppData would leave the link pointing at a folder only Symlinker can see, and uninstalling would delete the data.

So in the Store version, LinkCreator now refuses to move into AppData:

  • Elevation.IsPackaged() checks GetCurrentPackageFullName to see whether the process runs from a package
  • The check runs before the move confirmation and before any UAC prompt, so nothing on disk changes
  • New string MoveIntoAppDataUnsupported in all 9 languages
  • ClickOnce and portable builds are unaffected

Other changes

  • build-msix.ps1 fails if the package declares any capability besides runFullTrust
  • Store README: justification text covers only runFullTrust
  • CLAUDE.md: why only runFullTrust is needed, and the AppData limitation under Known Limitations

Tests

  • IsPackaged_IsFalse_OutsideAnMsixPackage
  • Move_IntoAppData_IsRefused_InTheStorePackage
  • Move_OutOfAppData_Works_InTheStorePackage
  • Move_IntoAppData_Works_OutsideTheStorePackage

Locally: 176 tests, 173 passed, 3 skipped (symbolic link tests need Developer Mode). CI runs elevated, so it covers those and the coverage gate.

After merging

  1. Tag v4.3.1 (the v4.3.0 bundle still declares the denied capabilities)
  2. Make a new submission in Partner Center with the 4.3.1 bundle

🤖 Generated with Claude Code

amd989 and others added 2 commits November 16, 2026 16:01
Partner Center denied allowElevation and unvirtualizedResources. Neither
is needed: the link helper's runas launch shows UAC without
allowElevation, and mklink runs in cmd.exe, which writes to the real
AppData. build-msix.ps1 now fails if the package declares anything
besides runFullTrust.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
In the MSIX package, new files and folders Symlinker creates under
AppData go to the package's private copy, so a move into AppData would
leave the link pointing at an empty folder. The Store version now shows
a message and stops before anything changes. Moving out of AppData and
linking into AppData without moving still work.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@amd989
amd989 merged commit 9a8aca9 into master Nov 16, 2026
1 check passed
@amd989
amd989 deleted the fix/store-capabilities branch November 16, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant